Files

T

Zakaria El OrcheandClaude Opus 5 580417e952 feat(ext-vite): replace the web bundler with a Vite extension and its Maven plugin

flash-ext-vite runs Vite's dev server in DEV and otherwise serves the build from the
classpath, read straight from the directory or jar with no manifest. The Maven plugin
flash-ext-vite-maven-plugin builds the frontend at prepare-package and packages it
there, so mvn package makes a jar that serves its own frontend and mvn test needs no
Node. Three overrides remain (root, devPort, basePath); the package manager is read
from the nearest lockfile.

Serving fixes what the bundler got wrong: Vite's hashed files under assets/ are
cached as immutable instead of revalidated, HEAD reports the real Content-Length, a
missing asset is a 404 instead of the index, 304s carry ETag and Cache-Control, and
gzip respects q=0 and is prepared at boot. Every response header is pre-encoded, so
serving allocates nothing, which is what Response.type(byte[]) is for. Vite stops
with the app through onClose, and a lockfile change reinstalls before restarting.

The modes, strategies, logging and command-safety options, the asset-source
abstraction, the manifest and the Jackson dependency are gone: 1,535 lines of main
code become 480, plus 84 for the plugin.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-22 15:47:28 +00:00

4.7 KiB

Raw Blame History

Flash — Agent Guidelines

This document defines the conventions and rules that all agents (AI or human) must follow when working on this repository. Read it entirely before making any change.

Git Workflow

Branch Naming

Type	Pattern	Example
New feature	`feature/<scope>/<short-description>`	`feature/ext-oidc/pkce-support`
Bug fix	`fix/<scope>/<short-description>`	`fix/core/router-npe`
Hotfix on released version	`hotfix/<version>/<short-description>`	`hotfix/2.0.1/auth-bypass`
CI/infra changes	`feature/ci/<short-description>`	`feature/ci/add-snapshot-workflow`

Rules:

Always branch from master.
Branch names are lowercase, words separated by -.
Never push directly to master.
Never create develop, release/*, or any other long-lived branch.

Commit Messages — Conventional Commits

Format: <type>(<scope>): <short description>

Type	When to use
`feat`	New feature
`fix`	Bug fix
`refactor`	Code change without feature/fix
`test`	Adding or updating tests
`docs`	Documentation only
`chore`	Build, deps, tooling — no production code
`ci`	Changes to GitHub Actions workflows

Allowed scopes: core, testing, ext-jackson, ext-openapi, ext-oidc, ext-routeviewer, ext-view-core, ext-view-jte, ext-view-thymeleaf, ext-limiter, ext-vite, ext-mcp, ext-validation, ext-scheduler, ext-data-core, ext-data-jdbc, ext-data-hibernate, ext-cache-core, ext-cache-caffeine, release, deps, ci.

Examples:

feat(ext-oidc): add PKCE support
fix(core): fix NPE in RouteHandler when path is null
chore(deps): upgrade jackson to 2.18.0
ci: add timeout to snapshot workflow
chore(release): 2.1.0

Pull Requests

Every branch must be merged via PR, never with a direct push.
PR title must follow Conventional Commits format.
CI (ci.yml) must be green before merging.
Squash merge is preferred for feature/* and fix/* to keep history clean.
Merge commit is preferred for hotfixes (preserves the fix commit intact).

Versioning

All modules share a single version defined in the root pom.xml (flash-parent).
Never change the version in child POMs — always and only in the parent.
Current scheme: MAJOR.MINOR.PATCH
- MAJOR: breaking API changes
- MINOR: new backward-compatible features
- PATCH: backward-compatible bug fixes on an already-released version
During development, master always carries a -SNAPSHOT version.
Never manually edit the version — versions are bumped exclusively by the prepare-release GitHub Actions workflow.

Release Process (for maintainers only)

Ensure master is green (CI passing).
Go to GitHub Actions → Prepare Release → Run workflow.
Input version (e.g. 2.1.0) and next_version (e.g. 2.2.0).
The workflow handles everything: bump, commit, tag, push.
The release workflow then triggers automatically on the tag.

Maven & Module Structure

Root POM: flash-parent — defines all dependency versions and plugin config.
flash module: the core framework JAR.
flash-testing module: JUnit 5 harness for testing Flash applications. Deliberately not under flash-extensions/ — it is not something you install(), and it carries junit-jupiter-api at compile scope.
flash-extensions POM: aggregator for all extension modules.
Extensions live under flash-extensions/flash-ext-*/.
When adding a new extension:
1. Add the module to flash-extensions/pom.xml <modules>.
2. Add the dependency to flash-extensions/pom.xml <dependencyManagement>.
3. Add the dependency to the root pom.xml <dependencyManagement>.
4. Do not declare a <version> in the new module's POM — it inherits from the parent.

CI/CD Pipelines

Workflow	Trigger	What it does
`ci.yml`	Push to any branch, PR to master	Compile + test — required gate
`snapshot.yml`	Push to `master`	Deploy `-SNAPSHOT` to `maven.relism.dev/snapshots`
`prepare-release.yml`	Manual `workflow_dispatch`	Bump version, commit, tag, push
`release.yml`	Push of tag `v*`	GPG sign, deploy to `/releases`, JavaDoc to GitHub Pages, GitHub Release

Agents must never manually trigger prepare-release or modify version strings.

What Agents Must NOT Do

Push directly to master or gh-pages.
Manually edit <version> tags in any POM.
Add new <repositories> or <distributionManagement> entries without explicit instruction.
Modify .github/workflows/*.yml files without explicit instruction.
Commit generated files (target/, *.class, *.versionsBackup).
Use git push --force on any branch.

4.7 KiB Raw Blame History